Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: infer self & Self HIR types #564

Merged
merged 5 commits into from
Jun 5, 2024
Merged

feat: infer self & Self HIR types #564

merged 5 commits into from
Jun 5, 2024

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Jun 1, 2024

No description provided.

@Wodann Wodann added the type: feat New feature or request label Jun 1, 2024
@Wodann Wodann added this to the Mun v0.6.0 milestone Jun 1, 2024
@Wodann Wodann requested a review from baszalmstra June 1, 2024 23:08
@Wodann Wodann self-assigned this Jun 1, 2024
@Wodann Wodann removed the request for review from baszalmstra June 2, 2024 04:39
@Wodann Wodann requested a review from baszalmstra June 2, 2024 05:50
@codecov Codecov
Copy link

codecov bot commented Jun 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.08130% with 49 lines in your changes missing coverage. Please review.

Project coverage is 87.30%. Comparing base (b68a952) to head (0154148).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/mun_hir/src/item_tree.rs 38.88% 11 Missing ⚠️
crates/mun_hir/src/resolve.rs 76.08% 11 Missing ⚠️
crates/mun_hir/src/ty/infer.rs 41.66% 7 Missing ⚠️
crates/mun_hir/src/semantics.rs 0.00% 5 Missing ⚠️
crates/mun_hir/src/item_tree/pretty.rs 66.66% 3 Missing ⚠️
crates/mun_language_server/src/to_lsp.rs 25.00% 3 Missing ⚠️
crates/mun_codegen/src/ir/body.rs 0.00% 2 Missing ⚠️
crates/mun_hir/src/name.rs 0.00% 2 Missing ⚠️
crates/mun_language_server/src/completion/item.rs 0.00% 2 Missing ⚠️
crates/mun_hir/src/expr.rs 93.75% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@           Coverage Diff            @@
##             main     #564    +/-   ##
========================================
  Coverage   87.30%   87.30%            
========================================
  Files         276      274     -2     
  Lines       32035    32543   +508     
========================================
+ Hits        27968    28413   +445     
- Misses       4067     4130    +63

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baszalmstra baszalmstra mentioned this pull request Jun 4, 2024
Open
4 tasks
@Wodann Wodann merged commit 3884019 into main Jun 5, 2024
18 of 19 checks passed
@Wodann Wodann deleted the feat/self-hir branch June 5, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees

@Wodann Wodann

Labels
type: feat New feature or request
Projects
None yet
Milestone
Mun v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Wodann @baszalmstra